[@azure-tools/cadl-ranch-specs] - Handle PassOnCode, Remove Handler & Remove commonapi.ts file #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarangan12
requested review from
iscai-msft,
lmazuel,
m-nash,
joheredi,
srnagar,
weidongxu-microsoft,
tadelesh and
timotheeguerin
as code owners
🦋 Changeset detectedLatest commit: 0a0f8d5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
timotheeguerin
approved these changes
Oct 16, 2024
packages/cadl-ranch-specs/http/azure/client-generator-core/access/mockapi.ts
Show resolved
Hide resolved
...cadl-ranch-specs/http/azure/resource-manager/models/common-types/managed-identity/mockapi.ts
Outdated
Show resolved
Hide resolved
|
@sarangan12 I merged a PR that contains conflicts with your PR: It reorganized ARM scenarios, mostly renames. Let me know if you run into any issues. |
github-merge-queue bot
pushed a commit
to microsoft/typespec
that referenced
this pull request
Oct 17, 2024
for Azure/cadl-ranch#755, as some tests validate the exact value of some parameter/property. for the 2 file with only format change, I guess the reason is Alan enabled spotless on emitter Java code (so `mvn package` would automatically format the code)
tadelesh
reviewed
Oct 17, 2024
packages/cadl-ranch-specs/http/azure/client-generator-core/access/mockapi.ts
Show resolved
Hide resolved
tadelesh
reviewed
Oct 18, 2024
github-merge-queue bot
pushed a commit
to microsoft/typespec
that referenced
this pull request
Oct 21, 2024
… tests (#4799) While working with China Team in Azure/cadl-ranch#755, I have found that a few changes are required in the specs to handle the test success in `http-client-java`, `http-client-net` and `http-client-python` packages. This PR handles those changes. The scenarios are also validated using the `test:e2e` script. Please review and approve the PR. Thanks
swatkatz
pushed a commit
to swatkatz/typespec
that referenced
this pull request
Nov 5, 2024
for Azure/cadl-ranch#755, as some tests validate the exact value of some parameter/property. for the 2 file with only format change, I guess the reason is Alan enabled spotless on emitter Java code (so `mvn package` would automatically format the code)
swatkatz
pushed a commit
to swatkatz/typespec
that referenced
this pull request
Nov 5, 2024
… tests (microsoft#4799) While working with China Team in Azure/cadl-ranch#755, I have found that a few changes are required in the specs to handle the test success in `http-client-java`, `http-client-net` and `http-client-python` packages. This PR handles those changes. The scenarios are also validated using the `test:e2e` script. Please review and approve the PR. Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consists of of the following changes:
passOnSuccessinstead ofpassOnCode. In this PR, it is changed back topassOnCode.typespecrepository.test:e2escript broke. Now, in themainbranch -cadl-ranch-specsrepository, if you run thepnpm test:e2escript, it will error out. This is happening because in one of the scenario, the way array's are expected and the way axios is sending it. But, with thehandlercode removed this is automatically fixed.commonapi.tsunderautheticationfolder is no longer required. That file is removed.Please review and approve the PR. Thanks